Skip to content
This repository was archived by the owner on Mar 25, 2018. It is now read-only.

security: Adding page to about section #72

Merged
merged 2 commits into from
Jan 31, 2015
Merged

security: Adding page to about section #72

merged 2 commits into from
Jan 31, 2015

Conversation

geek
Copy link
Member

@geek geek commented Jan 31, 2015

Content comes from @evilpacket in PR #60

@evilpacket
Copy link

@geek thanks for making this go. I apologize for not being able to touch up the various suggestions. This is great.

@geek
Copy link
Member Author

geek commented Jan 31, 2015

@evilpacket I just want to make sure you can say that node at least has a security page when you present at node summit!

@@ -0,0 +1 @@
{ "template": "doc/about.html", "title": "Security" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing newline

@robertkowalski
Copy link
Contributor

small issue: please add the link also to: https://github.com/joyent/node-website/blob/master/doc/about/advisory-board/template.html#L37-L46 - the advisory board has an own template

@robertkowalski
Copy link
Contributor

+1 after adressing the minor nits I found, great work everybody!

@geek
Copy link
Member Author

geek commented Jan 31, 2015

@robertkowalski all fixed up

@robertkowalski
Copy link
Contributor

+1

@robertkowalski
Copy link
Contributor

merge it! :)

geek added a commit that referenced this pull request Jan 31, 2015
security: Adding page to about section
@geek geek merged commit 774d14c into nodejs:master Jan 31, 2015

- The security report is received and is assigned a primary handler. This person will coordinate the fix and release
process. The problem is confirmed and a list of all affected versions is determined. Code is audited to find any
potential similar problems. Fixes are prepared for all releases which are still under maintenance. These fixes are not

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding

Fixes are prepared for all releases which are still under maintenance

Are the releases under maintenance documented somewhere? It is confusing for some users at least, so I think we should probably have that information easily available on the website.

@misterdjules
Copy link

@evilpacket @geek @robertkowalski Thank you!

@misterdjules
Copy link

@geek @robertkowalski I don't see the security page online. When is the next upload/deploy scheduled for the website?

@geek
Copy link
Member Author

geek commented Feb 4, 2015

@misterdjules trying to determine if I need the core teams approval first. @tjfontaine do you know if I can just upload the new security page?

@tjfontaine
Copy link
Contributor

I think this is fine, the content is fairly non-controversial and the truth -- I say go for it. In general my opinion is you don't need to seek core team approval unless you think it's changing process for the core team. But we will discuss on the call tomorrow.

@geek
Copy link
Member Author

geek commented Feb 4, 2015

The site is updated, the security page is published: http://nodejs.org/about/security/

@misterdjules
Copy link

@geek @robertkowalski @evilpacket Thanks again 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants